While a broker isn't (usually) licensed to give tax advice, if they invest themselves they often have a pretty good handle on it and can make sure your financial structure is as tax effective as possible.
Your plan sounds sensible - use debt to buy investments and cash to buy homes. BUT if...