Agreed, LOCs are generally more expensive than regular loans and don't add any benifit over a properly structured regular loan.
The offset saves you about 7% interest, it's not taxable. A savings account earns you about 5% interest which is taxable, effectively meaning youo'll earn about 3-4%...