that thread was very good.
cannot give legal advice but will offer my opinion. i think it is a good thing to have baseline details of what is brought into a relationship.
being totally practical before any life changing event, especially if it involves contracts etc, i can see no harm in legal advice.
entering a new partnership romantic or otherwise.
premarriage counselling should cover all aspects including finances joint or otherwise. it becomes more complicated if there have been prior relationships and related issues.
if nothing else it would facilitate frank discussion between the couple regarding these issues and explore expectations.
it would provide clarity for later. i would also combine the interview/process with drawing up/reviewing/changing wills. necessary for marriage anyway.
each person then knows where they stand now and for the future.
do not know your age group Grace, but even organising enduring power of attorney is not a bad idea too, to cover decisions related to capacity if confronted with serious health events. legal advice will guide you. regards.